Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servlet-based UserDetailsServiceAutoConfiguration is active in a reactive app #43334

Closed
wants to merge 1 commit into from
Closed

Servlet-based UserDetailsServiceAutoConfiguration is active in a reactive app #43334

wants to merge 1 commit into from

Conversation

BenchmarkingBuffalo
Copy link
Contributor

The UserDetailsServiceAutoConfiguration is only to be active in a servlet based web application

See gh-43326

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2024
@BenchmarkingBuffalo BenchmarkingBuffalo force-pushed the 43326-servlet-based-UserDetailsServiceAutoConfiguration-is-active-in-a-reactive-app branch 2 times, most recently from 0fcf2c2 to 9cb236c Compare December 1, 2024 01:17
@BenchmarkingBuffalo
Making UserDetailsServiceAutoConfiguration conditional
9cb236c 
The UserDetailsServiceAutoConfiguration is only to be active in a servlet based web application

See spring-projectsgh-43326
@mhalbritter mhalbritter changed the title Making UserDetailsServiceAutoConfiguration conditional Servlet-based UserDetailsServiceAutoConfiguration is active in a reactive app Dec 2, 2024
@mhalbritter mhalbritter added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 2, 2024
@mhalbritter mhalbritter added this to the 3.4.x milestone Dec 2, 2024
@mhalbritter mhalbritter mentioned this pull request Dec 2, 2024
Closed
@mhalbritter mhalbritter self-assigned this Dec 2, 2024
@sephiroth-j
Copy link

It would be consequent to make ReactiveUserDetailsServiceAutoConfiguration conditional as well.

@mhalbritter mhalbritter mentioned this pull request Dec 2, 2024
Closed
@mhalbritter
Copy link
Contributor

It would be consequent to make ReactiveUserDetailsServiceAutoConfiguration conditional as well.

I've opened #43345.

mhalbritter pushed a commit that referenced this pull request Dec 2, 2024
@BenchmarkingBuffalo @mhalbritter
Make UserDetailsServiceAutoConfiguration conditional on servlet app
c5d41f1 
See gh-43334
mhalbritter added a commit that referenced this pull request Dec 2, 2024
@mhalbritter
Polish "Make UserDetailsServiceAutoConfiguration conditional on servl…
ff9fde0 
…et app"

See gh-43334
@mhalbritter
Copy link
Contributor

Thanks @BenchmarkingBuffalo !

@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.1 Dec 2, 2024
@kse-music kse-music mentioned this pull request Dec 3, 2024
Closed
@Netyyyy Netyyyy mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@BenchmarkingBuffalo @sephiroth-j @mhalbritter @spring-projects-issues