spring-boot-maven-plugin sets imagePlatform even if it's empty #43424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld a Docker image
|
@vonZeppelin Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@vonZeppelin Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
changed the title
mhalbritter
added
type: bug
mhalbritter
changed the title
mhalbritter
pushed a commit
that referenced
this pull request
Dec 5, 2024
mhalbritter
added a commit
that referenced
this pull request
Dec 5, 2024
|
Thanks @vonZeppelin ! |
ndwlocatieservices
added a commit
to ndwnu/nls-routing-map-matcher
that referenced
this pull request
Dec 31, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.springboot:test](https://dev.azure.com/ndwnu/NLS/_git/nls-springboot) ([source](https://dev.azure.com/ndwnu/NLS/_git/nls-springboot)) | test | patch | `8.0.1` -> `8.0.2` | | [com.google.guava:guava](https://github.com/google/guava) | compile | minor | `33.3.1-jre` -> `33.4.0-jre` | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.4.0` -> `3.4.1` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)</summary> ### [`v3.4.1`](https://github.com/spring-projects/spring-boot/releases/tag/v3.4.1) [Compare Source](spring-projects/spring-boot@v3.4.0...v3.4.1) ##### 🐞 Bug Fixes - KafkaProperties fail to build SSL properties when the bundle name is an empty string [#​43563](spring-projects/spring-boot#43563) - Diagnostics are poor when property resolution throws a ConversionFailedException [#​43559](spring-projects/spring-boot#43559) - SpringApplicationShutdownHandlers do not run in deterministic order [#​43536](spring-projects/spring-boot#43536) - Unable to find a `@SpringBootConfiguration` results in misleading error message [#​43507](spring-projects/spring-boot#43507) - With multiple ResourceHandlerRegistrationCustomizer beans in the context, only one of them is used [#​43497](spring-projects/spring-boot#43497) - Unable to use Docker Compose support when mixing dedicated and shared services [#​43472](spring-projects/spring-boot#43472) - Kafka dependency management does not include the kafka-server module [#​43454](spring-projects/spring-boot#43454) - Docker API version is incorrectly reported when '/\_ping\` calls fail and version should be fixed [#​43452](spring-projects/spring-boot#43452) - Methods to build producer / consumer properties from KafkaProperties are inconvienenent to use without an SSL bundle [#​43448](spring-projects/spring-boot#43448) - Failures in -Djarmode=tools do not consistently return a non-zero exit [#​43436](spring-projects/spring-boot#43436) - HttpComponentsClientHttpRequestFactoryBuilder replaces the existing defaultRequestConfigCustomizer rather than adding to it [#​43429](spring-projects/spring-boot#43429) - spring-boot-maven-plugin sets imagePlatform even if it's empty [#​43424](spring-projects/spring-boot#43424) - OnBeanCondition fails to match on annotations when using Scoped ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Docker image cannot be built with the spring-boot-maven-plugin:3.4.0 if Docker API version is less than 1.41. In particular, a Spring Boot project builds are failing in Bitbucket pipelines when no 'imagePlatform' option configured for the project with the following error
Using an empty
<imagePlatform/>tag in thepom.xmldoesn't help as Maven, most probably, assigns an empty string to the corresp. Java property.The proposed fix is to check the config property for both null and empty string values.