Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka dependency management does not include the kafka-server module #43450

Closed

Conversation

sobychacko
Copy link
Contributor

Apache Kafka now ships a new module, kafka-server, since the 3.7.0 release. The 3.9.0 kafka-client introduced some breaking changes that require this dependecy for the EmbeddedKafka support in Spring for Apache Kafka. This commit adds this dependecny for Spring Boot based Spring Kafka projects.

Apache Kafka now ships a new module, kafka-server, since the 3.7.0 release.
The `3.9.0` kafka-client introduced some breaking changes that require this dependecy
for the `EmbeddedKafka` support in Spring for Apache Kafka. This commit adds this dependecny
for Spring Boot based Spring Kafka projects.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 9, 2024
@philwebb
Copy link
Member

philwebb commented Dec 9, 2024

@sobychacko @artembilan Do you consider this a bug (something for 3.3 or 3.4) or an enhancement (something to wait for 3.5).

@philwebb philwebb added the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Dec 9, 2024
@artembilan
Copy link
Member

It is hard to judge since it works with currently included Kafka client, but a new one (3.9.0), which we are trying to be compatible, doesn't work as is. That kafka-server has to be included.
Our goal is to not have next minor version for Spring Kafka, but rather keep the current one compatible with the latest client version and just aim for 4.0 next year, where Kafka Client 4.0 should appear as well.

It is not too hard to include that dependency into the target project, but might be very convenient just to override version and that's it.
At the same time, we include into Spring Boot deps management many other Kafka libs, so, since this one is missed for while (https://mvnrepository.com/artifact/org.apache.kafka/kafka-server), the fix might be applied for Spring Boot 3.3 as well.
That's where we have started to support Kafka client 3.7.x.

@philwebb
Copy link
Member

philwebb commented Dec 9, 2024

I think it's probably safe to apply the fix to 3.3. It's a managed dependency, but not actually pulled in by default.

@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team labels Dec 9, 2024
@philwebb philwebb added this to the 3.3.x milestone Dec 9, 2024
@philwebb philwebb changed the title Add kafka-server module dependency Kafka dependency management does not include the kafka-server module Dec 9, 2024
@snicoll snicoll modified the milestones: 3.3.x, 3.3.7 Dec 10, 2024
snicoll pushed a commit that referenced this pull request Dec 10, 2024
Apache Kafka now ships a new module, kafka-server, since the 3.7.0
release. The `3.9.0` kafka-client introduced some breaking changes that
require this dependecy for the `EmbeddedKafka` support in Spring for
Apache Kafka.

This commit adds this dependecny for Spring Boot based Spring Kafka
projects.

See gh-43450
@snicoll snicoll closed this in 5db3fee Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants