Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smallrye Mutiny support #2471

Closed
wants to merge 1 commit into from

Conversation

hantsy
Copy link
Contributor

@hantsy hantsy commented Sep 28, 2021

aligned to Spring 5.3.10 which added SmallRye Mutiny support, see: spring-projects/spring-framework#27331

@hantsy
Copy link
Contributor Author

hantsy commented Sep 28, 2021

depends on spring-projects/spring-data-build#1545

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 28, 2021
@mp911de mp911de self-assigned this Oct 5, 2021
@mp911de
Copy link
Member

mp911de commented Oct 5, 2021

Thanks a lot for your contribution. For the time being we would like to include only the addition of Mutiny to our registry and adapter infrastructure. Care to remove the repository base interfaces as these aren't required and we do not have native implementations using Mutiny?

@mp911de mp911de added status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 5, 2021
@mp911de mp911de added this to the 2.6 RC1 (2021.1.0) milestone Oct 5, 2021
@hantsy
Copy link
Contributor Author

hantsy commented Oct 5, 2021

Is there any Repository implementations using RxJava 2/3?

I would like to add it firstly, and then add a standalone spring data hibernate module(reactive and blocking).

Currently Spring Data JPA does not support reactive APIs, but Hibernate Reative provides JPA like APIs to reactive world, Hibernate Reactive has built-in SmallRye Mutiny support.

For those RDBMS developers who are familiar with JPA, migrating to Hibernate Reactive is more reasonable than using R2dbc(not mature as JPA/Jdbc till now).

@mp911de
Copy link
Member

mp911de commented Oct 5, 2021

would like to add it firstly, and then add a standalone spring data hibernate module(active and blocking).

For the time being, it can be a local interface in a Spring Data Hibernate Reactive module.

Is there any Repository implementations using RxJava 2/3?

Kind of. With Spring Data 2.x we support RxJava 1 while there is no base RxJava 1 base repository. Generally, Spring Data creates adapters around reactive types so one can use e.g. MongoDB through RxJava 2/3. In the early days, Couchbase was built on RxJava 1 but the repository could be used through ReactiveCrudRepository.

@hantsy
Copy link
Contributor Author

hantsy commented Oct 5, 2021

I see, the ReactiveAdapter can convert between them, for Spring projects, Reactor is enough.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Oct 5, 2021
@mp911de
Copy link
Member

mp911de commented Oct 6, 2021

Do you want to remove both repository base interfaces from the PR or should I take care of this?

@hantsy
Copy link
Contributor Author

hantsy commented Oct 6, 2021

@mp911de I will remove them soon.

@hantsy
Copy link
Contributor Author

hantsy commented Oct 6, 2021

@mp911de Updated and rebased on main.

@mp911de mp911de closed this in d182757 Oct 6, 2021
mp911de added a commit that referenced this pull request Oct 6, 2021
Add since and author tags. Add ticket references to tests. Reformat code.

See #2471
@mp911de mp911de removed the status: feedback-provided Feedback has been provided label Oct 6, 2021
@mp911de
Copy link
Member

mp911de commented Oct 6, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de changed the title chore: add Smallrye Mutiny support Add Smallrye Mutiny support Oct 6, 2021
mp911de added a commit that referenced this pull request Oct 6, 2021
Add since and author tags. Add ticket references to tests. Reformat code.

See #2471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants