Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation allowDiskUse should not be false by default #4664

Closed
a-mountain opened this issue Mar 18, 2024 · 0 comments
Closed

Aggregation allowDiskUse should not be false by default #4664

a-mountain opened this issue Mar 18, 2024 · 0 comments
Assignees
Labels
type: enhancement A general enhancement

Comments

@a-mountain
Copy link

a-mountain commented Mar 18, 2024

Starting from version 6, Mongo has server parameter allowDiskUseByDefault which is true by default. In Spring allowDiskUse for aggregation pipelines is false by default (because of using boolean) which means Spring always implicitly overrides Mongo default beheviour. Queries have no such issue. I think Spring should not set any parameters silently overriding Mongo default behaviour

public class AggregationOptions implements ReadConcernAware, ReadPreferenceAware {
...
private final boolean allowDiskUse;
...
}
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 18, 2024
@mp911de mp911de self-assigned this Mar 19, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 19, 2024
@mp911de mp911de changed the title Aggregation - AllowDiskUse should not be false by default Aggregation allowDiskUse should not be false by default Mar 19, 2024
@christophstrobl christophstrobl added this to the 4.3 RC1 (2024.0.0) milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants