Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let QueryByExampleRedisExecutor implement ListQueryByExampleExecutor #2880

Closed
sergey-morenets opened this issue Mar 25, 2024 · 1 comment
Closed
Assignees
Labels
type: enhancement A general enhancement

Comments

@sergey-morenets
Copy link

Hi

There's special "Query By Example" section in Spring Data Redis reference documentation: https://docs.spring.io/spring-data/redis/reference/redis/redis-repositories/query-by-example.html

However it mentions QueryByExampleExecutor type only:

interface PersonRepository extends QueryByExampleExecutor<Person> {
}

But Spring Data Redis 3.0 introduced new type ListQueryByExampleExecutor which is more convenient for list operations. However it's not mentioned in this section.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 25, 2024
@mp911de mp911de self-assigned this Apr 15, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2024
@mp911de mp911de changed the title Query By Example section misses ListQueryByExampleExecutor type usage Let QueryByExampleRedisExecutor implement ListQueryByExampleExecutor Apr 16, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed type: documentation A documentation update labels Apr 16, 2024
@mp911de
Copy link
Member

mp911de commented Apr 16, 2024

QueryByExampleRedisExecutor doesn't implement ListQueryByExampleExecutor in the first place, so we need to adopt the implementation first.

@mp911de mp911de added this to the 3.3 GA (2024.0.0) milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants