Parse request path only once during routing [SPR-15397]

[spring-projects-issues]

Brian Clozel opened SPR-15397 and commented

Since the introduction of PathPatternParser in #19112, the WebFlux framework is using it within the ParsingPatchMatcher to match incoming requests against route patterns.

Attempts to integrate the PathPatternParser directly and leverage its full potential were made in the previous milestone but were reverted in fa4202f, after we fully understood that this strategy could be improved in several ways:

• incoming requests should be parsed once at the beginning of the request pipeline, at the HandlerMapping level; their path should be parsed to extract the path, path parameters and file extension informations, and more if necessary
• this "parsed request" information should be made available to the rest of the request pipeline, by using an exchange attribute
• the HttpRequestPathHelper does not need to leak in multiple places anymore

---

Issue Links:

• When using ParsingPathMatcher in MVC user should not have to also explicitly set suffix matching [SPR-15303] #19868 When using ParsingPathMatcher in MVC user should not have to also explicitly set suffix matching

[spring-projects-issues]

Rob Winch commented

I noticed that LookupPath returns a String and it is extracted based on anything after a ;.

However, the path /1;a=b/2;c=d/3 provides path variables of a=b and c=d which is multiple values and probably not compatible with the String return type. You can also see that the path variables are from the ; to the next path separator / and each path segment can contain path variables.

I'm going to reopen this ticket so this can be addressed.

[spring-projects-issues]

Rossen Stoyanchev commented

Equivalent code used in Spring MVC.

[spring-projects-issues]

Brian Clozel commented

Good catch, thanks!