Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent non-exposure of inherited annotations in AnnotationMetadata #22766

Closed
jhoeller opened this issue Apr 8, 2019 · 0 comments
Closed

Consistent non-exposure of inherited annotations in AnnotationMetadata #22766

jhoeller opened this issue Apr 8, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2 M1

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Apr 8, 2019

Historically, StandardAnnotationMetadata operates against Class.getAnnotations(), potentially seeing inherited annotations as well. This is inconsistent within the AnnotationMetadata abstraction since its ASM implementation operates against locally declared annotations only.

Let's make this consistent in 5.2 since inherited annotations aren't relevant for our component and configuration class introspection purposes, and in particular should be consistently ignored across Class-declared and component-scanned beans.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Apr 8, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Apr 8, 2019
@jhoeller jhoeller self-assigned this Apr 8, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M1
Development

No branches or pull requests
1 participant
@jhoeller