Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish StartupStep interface "tags" method #25678

Closed
bclozel opened this issue Sep 2, 2020 · 0 comments
Closed

Polish StartupStep interface "tags" method #25678

bclozel opened this issue Sep 2, 2020 · 0 comments
Assignees
@bclozel
Labels
type: task A general task
Milestone
5.3 RC1

Comments

@bclozel
Copy link
Member

bclozel commented Sep 2, 2020

Currently the StartupStep interface has a Tags tags() method that exposes the immutable collection of Tags.

We should update the Javadoc. Right now it's mentioning a "mutable" collection, but the mutating methods have been moved in the meantime to the StartupStep interface directly.

Also, for consistency we should make the tags a proper getter method.
@bclozel bclozel added the type: task A general task label Sep 2, 2020
@bclozel bclozel added this to the 5.3 RC1 milestone Sep 2, 2020
@bclozel bclozel self-assigned this Sep 2, 2020
@bclozel bclozel changed the title Polish StartupStep interface "tags" Polish StartupStep interface "tags" method Sep 2, 2020
@bclozel bclozel closed this as completed in 88249b2 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: task A general task
Projects
None yet
Milestone
5.3 RC1
Development

No branches or pull requests
1 participant
@bclozel