Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a public mechanism for detecting if AOT processing is in progress #33388

Closed
wilkinsona opened this issue Aug 14, 2024 · 1 comment
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

Affects: 6.1

We have a few places in Spring Boot where we need to detect if AOT processing is in progress. spring-projects/spring-boot#41838 is another case. At the moment, detection relies upon checking the spring.aot.processing system property that's set by AbstractAotProcessor. The property's name is private so we're depending on what's otherwise an implementation detail of Framework which doesn't feel great.

Given that we already have a need for this detection and it appears to be growing, it would be good to have an "official" way to do it. Perhaps the constant that defines the property's name could be made public or, going a step further, perhaps a method could be added to AotDetector?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 14, 2024
@jhoeller jhoeller added the in: core Issues in core modules (aop, beans, core, context, expression) label Aug 14, 2024
@jhoeller jhoeller added type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 22, 2024
@jhoeller jhoeller added this to the 6.2.x milestone Aug 22, 2024
@jhoeller jhoeller self-assigned this Sep 26, 2024
@jhoeller jhoeller modified the milestones: 6.2.x, 6.2.0-RC2 Sep 26, 2024
@jhoeller
Copy link
Contributor

Let's make AbstractAotProcessor.AOT_PROCESSING public for 6.2 RC2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants