Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Kotlin code samples to a dedicated package #33845

Closed
sdeleuze opened this issue Nov 5, 2024 · 1 comment
Closed

Move Kotlin code samples to a dedicated package #33845

sdeleuze opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
status: declined A suggestion or change that we don't feel we should currently apply theme: kotlin An issue related to Kotlin support type: task A general task

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Nov 5, 2024

The upgrade to Kotlin 2 planned in #33629 is blocked by an error that happens during the compilation of Kotlin code samples due to duplicated classes between Java and Kotlin code samples, since they are using the same package and name.

After discussing with @philwebb and @rwinch, we agreed to try to solve this by using a dedicated package per language, maybe with a related convention. This will likely require evolving the include-code extension where I will potentially create a related PR.

That change will also avoid warnings/errors in the IDE:
image

@sdeleuze sdeleuze added type: task A general task theme: kotlin An issue related to Kotlin support labels Nov 5, 2024
@sdeleuze sdeleuze added this to the 7.0.x milestone Nov 5, 2024
@sdeleuze sdeleuze self-assigned this Nov 5, 2024
@sdeleuze
Copy link
Contributor Author

Another workaround has been implemented so I will decline that issue.

@sdeleuze sdeleuze closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
@sdeleuze sdeleuze removed this from the 7.0.x milestone Jan 14, 2025
@sdeleuze sdeleuze added the status: declined A suggestion or change that we don't feel we should currently apply label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply theme: kotlin An issue related to Kotlin support type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant