Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationEnhancer always return the old attributes #3425

Closed
crmky opened this issue Aug 16, 2024 · 2 comments · Fixed by #3428
Closed

AnnotationEnhancer always return the old attributes #3425

crmky opened this issue Aug 16, 2024 · 2 comments · Fixed by #3428

Comments

@crmky
Copy link

crmky commented Aug 16, 2024

In what version(s) of Spring for Apache Kafka are you seeing this issue?

3.1.7

Describe the bug

It seems AnnotationEnhancer introduced by #1818 always return old attributes instead of new attributes.

Refer to

@sobychacko
Copy link
Contributor

Looks like a bug. We will look at this today. Thanks!

@sobychacko
Copy link
Contributor

The newAttr is a reference to the old map - attr. However, there is a chance that the enhancer impls could change that reference. We will fix it.

sobychacko added a commit to sobychacko/spring-kafka that referenced this issue Aug 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
sobychacko added a commit to sobychacko/spring-kafka that referenced this issue Aug 16, 2024
Fixes: spring-projects#3425

Implement fix for issue spring-projects#3425 by modifying AnnotationEnhancer to return
the updated map after processing. This change ensures that all
annotation enhancements are properly reflected in the returned result.

Modifying an existing test to verify this behavior.
@sobychacko sobychacko added this to the 3.3.0-M2 milestone Aug 17, 2024
sobychacko added a commit that referenced this issue Aug 19, 2024
Fixes: #3425

Implement fix for issue #3425 by modifying AnnotationEnhancer to return
the updated map after processing. This change ensures that all
annotation enhancements are properly reflected in the returned result.

Modifying an existing test to verify this behavior.

**Auto-cherry-pick to `3.2.x` & `3.1.x`**
sobychacko added a commit that referenced this issue Aug 19, 2024
Fixes: #3425

Implement fix for issue #3425 by modifying AnnotationEnhancer to return
the updated map after processing. This change ensures that all
annotation enhancements are properly reflected in the returned result.

Modifying an existing test to verify this behavior.

**Auto-cherry-pick to `3.2.x` & `3.1.x`**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants