Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About AOP implementation, such as @Retryable #87

Closed
happyxiaofan opened this issue Sep 3, 2017 · 3 comments
Closed

About AOP implementation, such as @Retryable #87

happyxiaofan opened this issue Sep 3, 2017 · 3 comments
Labels

Comments

@happyxiaofan
Copy link

AspectJ (for post complier weave) or CGLIB(dynamic weave)

@dsyer
Copy link
Member

dsyer commented Dec 12, 2017

Is that a question? Feature request? Not sure how to respond since we already use AOP for @Retryable.

@dtitov
Copy link

dtitov commented Feb 20, 2018

Sorry, that might be off-topic here, but I didn't want to create an issue for this question.

I'm using spring-retry for retrying in Spring Cloud Config. So I have something like:

spring:
    application:
        name: ***
    cloud:
        config:
            ...
            failFast: true
            retry:
                max-attempts: 100
                max-interval: 100000

That works like a charm, but only as long as I have spring-boot-starter-aop on the application's classpath. If I remove AOP-dependency, retry functionality is working no more. My question is: why AOP dependency is not included to Spring Retry, so it can transitively and transparently come to my application without a need to declare it explicitly?

@artembilan
Copy link
Member

Spring Retry does not have transitive dependencies at all.
Everything is optional and in most cases compatible with wide range of Spring versions.
So, it is indeed expected that you have spring-context in your Spring Boot application which comes with a spring-aop as transitive dependency.

Closing as Works as Designed.

@artembilan artembilan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants