Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pagination while using ACL based @PostFilter #6736

Closed
SayakMukhopadhyay opened this issue Apr 3, 2019 · 3 comments
Closed

Support for pagination while using ACL based @PostFilter #6736

SayakMukhopadhyay opened this issue Apr 3, 2019 · 3 comments
Assignees
Labels
in: acl An issue in spring-security-acl status: duplicate A duplicate of another issue

Comments

@SayakMukhopadhyay
Copy link

Summary

When an entity repository is under ACL based security, it suffers from a huge issue of being unable to handle pagination. This has been previously been said due to how the paged result is fetched first and then ACL is applied over it which potentially would return less number of records than the page size. But this is an extremely common use case and as such a implementation would greatly benefit the community.

Actual Behavior

Currently, @PostFilter doesn't accept a Pageable type of returnObject due a failing type check. Even if the type check is overriden, it would not help since the problem with the less number of records than page size remains.

Expected Behavior

A paged response on @PostFilter should implicitly return a page of records containing only the permitted entries.

Configuration

I don't have a configuration but there is an implementation which works around this issue. But, I would prefer this to be an official implementation.

Version

This issue is present in all versions of Spring Security

Sample

https://github.com/lordlothar99/strategy-spring-security-acl provides an alternative implemetation.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 7, 2019
@connorsadlervelo
Copy link

This is a problem for us, too - will it be addressed?

@jzheaux
Copy link
Contributor

jzheaux commented Nov 13, 2019

Thanks, @SayakMukhopadhyay and @connorsadlervelo for your interest.

This is a duplicate of #2629, which is blocked by https://jira.spring.io/browse/DATACMNS-293 - please find the remaining details in those tickets.

@jzheaux jzheaux closed this as completed Nov 13, 2019
@jzheaux jzheaux added status: duplicate A duplicate of another issue in: acl An issue in spring-security-acl and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 13, 2019
@jzheaux jzheaux self-assigned this Nov 13, 2019
@henesm
Copy link

henesm commented May 31, 2023

Any updates? The "blocking" issue is not resolved either. Any solution after 10 years ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: acl An issue in spring-security-acl status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

5 participants