Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making FindByIndexNameSessionRepository a standalone interface #2115

Open
vpavic opened this issue Aug 10, 2022 · 1 comment
Open
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Comments

@vpavic
Copy link
Contributor

vpavic commented Aug 10, 2022

As discussed with @rwinch today, we could consider making FindByIndexNameSessionRepository a standalone interface. At present, it extends SessionRepository.

Some of the relevant points that we discussed:

  • users are encouraged to interact with sessions using their web framework's native session facilities (that is, Servlet's HttpSession of Spring WebFlux's WebSession) which means direct interaction with SessionRepository operations is not a common use case
  • OTOH FindByIndexNameSessionRepository operations are Spring Session's own thing
  • mixed usage of SessionRepository and FindByIndexNameSessionRepository isn't a common thing (Spring Boot's Actuator sessions endpoint is an outlier here) which means user impact from having latter not extend the former any more is expected to be insignificant
  • having FindByIndexNameSessionRepository as standalone allows users to implement their own indexing support without having to use a non-default SessionRepository implementation (for example, RedisSessionRepository vs RedisIndexedSessionRepository consideration)
  • this also somewhat impacts Provide an Actuator endpoint for non-indexed session repositories spring-boot#10827
@marcusdacoregio
Copy link
Contributor

This has been done for the reactive side as part of #2700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants