Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving terminal ui to its own module #847

Open
Tracked by #761
jvalkeal opened this issue Aug 6, 2023 · 0 comments
Open
Tracked by #761

Consider moving terminal ui to its own module #847

jvalkeal opened this issue Aug 6, 2023 · 0 comments
Labels
area/components Belongs ui components area/components-view Belongs ui view components
Milestone

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Aug 6, 2023

There's a lot of new code and while it's convenient to have it in a core package a new dependence to reactor is not optimal to have in a core itself. While we could try to make reactor optional it feels that separate module might be better. Not all want to use "UI" features.

At this point we also need to think older flow components as there is a plan to replace core representation layer in those to low level terminal ui components. This means those needs to live in a same module.

@jvalkeal jvalkeal added area/components Belongs ui components area/components-view Belongs ui view components labels Aug 6, 2023
@jvalkeal jvalkeal added this to the 3.2.0-M2 milestone Aug 6, 2023
@jvalkeal jvalkeal modified the milestones: 3.2.0-M2, 3.2.0-RC1 Sep 25, 2023
@jvalkeal jvalkeal modified the milestones: 3.2.0-RC1, 3.2.x Oct 20, 2023
@jvalkeal jvalkeal modified the milestones: 3.2.x, 3.3.x Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components Belongs ui components area/components-view Belongs ui view components
Projects
None yet
Development

No branches or pull requests

1 participant