Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ABNF to parse messages from String #3

Open
Tracked by #2
w4ll3 opened this issue Dec 3, 2021 · 2 comments
Open
Tracked by #2

Use ABNF to parse messages from String #3

w4ll3 opened this issue Dec 3, 2021 · 2 comments
Labels
siwe-rb SIWE Core Ruby package

Comments

@w4ll3
Copy link
Member

w4ll3 commented Dec 3, 2021 •
edited
Loading

This would improve maintainability if the message changes, right now Ruby doesn't have a good ABNF parser which makes this parsing quite difficult.
@w4ll3 w4ll3 mentioned this issue Dec 3, 2021
Closed
6 tasks
@w4ll3 w4ll3 changed the title message abnf parsing Use ABNF to parse messages from String Dec 3, 2021
@awoie awoie added the siwe-rb SIWE Core Ruby package label Mar 22, 2022
@mculp
Copy link

mculp commented Apr 15, 2022

You mean to tell me this 20 year old code isn't suitable? 😂

First time I've seen "20 years ago" in a github repo.

@mculp
Copy link

mculp commented Apr 15, 2022

this looks like it is maintained: https://github.com/dryruby/ebnf/blob/develop/examples/abnf/parser.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
siwe-rb SIWE Core Ruby package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mculp @w4ll3 @awoie