Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with system fonts #64

Closed
ghisvail opened this issue Jan 5, 2017 · 16 comments
Closed

Integration with system fonts #64

ghisvail opened this issue Jan 5, 2017 · 16 comments
Milestone

Comments

@ghisvail
Copy link
Contributor

ghisvail commented Jan 5, 2017

With the new release of QtAwesome v4.x, patching the code to use the system fonts produces a FontError, most likely due to a mismatch between the mdf5 sums of the vendored fonts compared to the system ones. Please remember that vendoring is strongly discouraged by Linux distributions, hence the need for an integration path.

I would like to discuss with you guys what the best course of actions would be to have QtAwesome work with system fonts without complicating the package maintenance burden. Shall, I just make a patch to disable the sum checking part of the code?

@ccordoba12 ccordoba12 added this to the v0.4.2 milestone Jan 5, 2017
@ccordoba12
Copy link
Member

I think the best solution is for us to add a constant in qtawesome/__init__.py, like this

SYSTEM_FONTS = False

So if this constant is false then we proceed with our hash verification in iconic_font.py and if not (e.g. after you patch QtAwesome to make it true) we just skip it.

@ghisvail, what do you think?

@ghisvail
Copy link
Contributor Author

ghisvail commented Jan 6, 2017

I like that, thanks @ccordoba12

@ghisvail
Copy link
Contributor Author

Do you have a fix I could apply on top of 0.4.1? I would like to try updating qtawesome in Debian before the freeze.

@ccordoba12
Copy link
Member

When is the freeze?

@ghisvail
Copy link
Contributor Author

Last date for upload should be on the 25th, but sooner would be better.

@ccordoba12
Copy link
Member

I'll work on this tomorrow.

@ghisvail
Copy link
Contributor Author

Thanks Carlos

@ghisvail
Copy link
Contributor Author

FYI, if all goes well, we should have spyder-3.0.2, qtpy-1.2.0 and qtawesome-0.4.x (0.4.2?) in Debian Stretch.

@ghisvail
Copy link
Contributor Author

I have also started a discussion with the packaging team to check whether we had enough time and resources to package spyder-3.1.0, which you just recently released. Congrats for the release by the way.

@ghisvail
Copy link
Contributor Author

The team is keen on getting spyder-3.1.0 out in Stretch, but we'd have to act fast (we have one downstream using spyder, so they'd need some time for testing).

Do you think you can have a version 0.4.1+ of qtawesome ready super soon? It does not have to be 0.4.2, just 0.4.1 + a patch applied on my end.

@ccordoba12
Copy link
Member

I'll release 0.4.2 in a couple of hours.

Also, there are a couple of bugs in Spyder 3.1.0, so we're going to release 3.1.1 in a couple of days, is that ok for you?

@ghisvail
Copy link
Contributor Author

we're going to release 3.1.1 in a couple of days

Depends what you define by "couple of days"...

is that ok for you?

We think it is worth the try.

@ccordoba12
Copy link
Member

Depends what you define by "couple of days"...

Saturday 21 at most, promised :-)

We think it is worth the try.

Great!

@ghisvail
Copy link
Contributor Author

Saturday 21 at most

That should leave us enough time, although the earlier the better.

I am on stand-by for the updates to qtawesome and spyder.

@ghisvail
Copy link
Contributor Author

@ccordoba12 Any news on the release? I can find some time tomorrow to work on the packaging, after that time will be scarce on my end.

Cheers,
Ghis

@ccordoba12
Copy link
Member

0.4.2 is up now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants