Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Do not discard completions that contain textEdit #10637

Closed
wants to merge 1 commit into from

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Nov 7, 2019

Description of Changes

This PR prevents a regression introduced on PR #10605

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@andfoy

@andfoy andfoy added this to the v4.0.0 milestone Nov 7, 2019
@andfoy andfoy self-assigned this Nov 7, 2019
@andfoy
Copy link
Member Author

andfoy commented Nov 7, 2019

Closed in favor of #10630

@andfoy andfoy closed this Nov 7, 2019
@andfoy andfoy deleted the fix_kite_completions branch November 7, 2019 21:09
@ccordoba12 ccordoba12 removed this from the v4.0rc2 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants