Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add Wrap lines checkbox to source menu #13496

Closed
wants to merge 1 commit into from

Conversation

arteagac
Copy link
Contributor

@arteagac arteagac commented Aug 7, 2020

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Implemented checkbox for "Wrap lines" in the Source menu. I tested it and this properly synchronizes with the Editor Preferences.
image

Issue(s) Resolved

Fixes #7997

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
arteagac

@maurerle
Copy link
Contributor

maurerle commented Nov 16, 2022

It would be very cool to merge this?
Should I readd that commit and create a PR to merge it into 5.x

I would also add the short cut Alt+Z to the action as it is quite common?

But adding a shortcut to a checkable action would need to add the register_action param to _create_checkable_action..

@dalthviz
Copy link
Member

Thanks for your interest in this @maurerle ! What do you think @arteagac (and sorry for such a late response 😅 )? Is it okay if @maurerle takes the commit here, and moves it to 5.x? Or would you like to work on this again and update it to be based on the 5.x branch? Let us know!

@dalthviz dalthviz changed the title Add Wrap lines checkbox to source menu PR: Add Wrap lines checkbox to source menu Nov 18, 2022
@arteagac
Copy link
Contributor Author

Hi @dalthviz and @maurerle,

Sure, @maurerle can go ahead and take the commit and move it to 5.x.

@ccordoba12
Copy link
Member

Thanks @arteagac for being ok with that! I'm going to close your pull request in favor of #20090 then.

@ccordoba12 ccordoba12 closed this Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants