[WIP] PR: Code analysis UX/UI improvements

spyder/config/main.py

@@ -353,6 +353,7 @@
               'history_filenames': [],
               'max_entries': 30,
               'project_dir': None,
+              'real_time_analysis': False,
               }),
             ('workingdir',
              {

spyder/plugins/editor/plugin.py

@@ -164,11 +164,18 @@ class Editor(SpyderPluginWidget, SpyderConfigurationObserver):
     sig_codeeditor_created = Signal(object)
     """
     This signal is emitted when a codeeditor is created.
+    """
+
+    sig_diagnostics_update = Signal(str, list)
+    """
+    This signal is emitted when new code analysis diagnostics are available.
 
     Parameters
     ----------
-    codeeditor: spyder.plugins.editor.widgets.codeeditor.CodeEditor
-        The codeeditor.
+    filename: str
+        The file filename.
+    diagnostics: list
+        The file code analysis diagnostics.
     """
 
     sig_codeeditor_deleted = Signal(object)
@@ -1795,6 +1802,7 @@ def register_editorstack(self, editorstack):
         editorstack.sig_save_bookmarks.connect(self.save_bookmarks)
         editorstack.sig_help_requested.connect(self.sig_help_requested)
         editorstack.sig_codeeditor_created.connect(self.sig_codeeditor_created)
+        editorstack.sig_diagnostics_update.connect(self.sig_diagnostics_update)
         editorstack.sig_codeeditor_changed.connect(self.sig_codeeditor_changed)
         editorstack.sig_codeeditor_deleted.connect(self.sig_codeeditor_deleted)
 

spyder/plugins/editor/widgets/codeeditor/lsp_mixin.py

@@ -114,6 +114,9 @@ class LSPMixin:
     #: Signal emitted when processing code analysis warnings is finished
     sig_process_code_analysis = Signal()
 
+    #: Signal emitted when diagnostics is defined/set
+    sig_diagnostics_update = Signal(str, list)
+
     # Used to start the status spinner in the editor
     sig_start_operation_in_progress = Signal()
 
@@ -512,6 +515,7 @@ def sync_symbols_and_folding(self):
     def process_code_analysis(self, diagnostics):
         """Process code analysis results in a thread."""
         self.cleanup_code_analysis()
+        self.sig_diagnostics_update.emit(self.filename, diagnostics)
         self._diagnostics = diagnostics
 
         # Process diagnostics in a thread to improve performance.

spyder/plugins/editor/widgets/editor.py

@@ -91,6 +91,7 @@ class EditorStack(QWidget, SpyderConfigurationAccessor):
     active_languages_stats = Signal(set)
     todo_results_changed = Signal()
     sig_update_code_analysis_actions = Signal()
+    sig_diagnostics_update = Signal(str, list)
     refresh_file_dependent_actions = Signal()
     refresh_save_all_action = Signal()
     text_changed_at = Signal(str, int)
@@ -2373,6 +2374,8 @@ def create_new_editor(self, fname, enc, txt, set_current, new=False,
         editor.sig_new_file.connect(self.sig_new_file)
         editor.sig_process_code_analysis.connect(
             self.sig_update_code_analysis_actions)
+        editor.sig_diagnostics_update.connect(
+            self.sig_diagnostics_update)
         editor.sig_refresh_formatting.connect(self.sig_refresh_formatting)
         editor.sig_save_requested.connect(self.save)
         language = get_file_language(fname, txt)

spyder/plugins/pylint/confpage.py

@@ -14,20 +14,27 @@
 from spyder.api.preferences import PluginConfigPage
 from spyder.api.translations import _
 from spyder.plugins.pylint.main_widget import (MAX_HISTORY_ENTRIES,
-                                               MIN_HISTORY_ENTRIES,
-                                               PylintWidget)
+                                               MIN_HISTORY_ENTRIES)
 
 
 class PylintConfigPage(PluginConfigPage):
 
     def setup_page(self):
-        settings_group = QGroupBox(_("Settings"))
-        save_box = self.create_checkbox(_("Save file before analyzing it"),
-                                        'save_before', default=True)
-
+        settings_group = QGroupBox(_("Real time code analysis"))
+        linter_selection_label = QLabel(
+            _("Choose if real time code analysis results or "
+              "manually requested Pylint executions results "
+              "should be shown")
+        )
+        real_time_box = self.create_checkbox(
+            _("Enable real time code analysis"),
+            'real_time_analysis',
+            default=False
+        )
         hist_group = QGroupBox(_("History"))
-        hist_label1 = QLabel(_("The following option will be applied at next "
-                               "startup."))
+        hist_label1 = QLabel(_("Choose how many results you want to store in "
+                               "the history results, pick a number between "
+                               "1-100."))
         hist_label1.setWordWrap(True)
         hist_spin = self.create_spinbox(
             _("History: "),
@@ -39,35 +46,18 @@ def setup_page(self):
             step=1,
         )
 
-        results_group = QGroupBox(_("Results"))
-        results_label1 = QLabel(_("Results are stored here:"))
-        results_label1.setWordWrap(True)
-
-        # Warning: do not try to regroup the following QLabel contents with
-        # widgets above -- this string was isolated here in a single QLabel
-        # on purpose: to fix spyder-ide/spyder#863.
-        results_label2 = QLabel(PylintWidget.DATAPATH)
-
-        results_label2.setTextInteractionFlags(Qt.TextSelectableByMouse)
-        results_label2.setWordWrap(True)
-
         settings_layout = QVBoxLayout()
-        settings_layout.addWidget(save_box)
+        settings_layout.addWidget(linter_selection_label)
+        settings_layout.addWidget(real_time_box)
         settings_group.setLayout(settings_layout)
 
         hist_layout = QVBoxLayout()
         hist_layout.addWidget(hist_label1)
         hist_layout.addWidget(hist_spin)
         hist_group.setLayout(hist_layout)
 
-        results_layout = QVBoxLayout()
-        results_layout.addWidget(results_label1)
-        results_layout.addWidget(results_label2)
-        results_group.setLayout(results_layout)
-
         vlayout = QVBoxLayout()
         vlayout.addWidget(settings_group)
         vlayout.addWidget(hist_group)
-        vlayout.addWidget(results_group)
         vlayout.addStretch(1)
         self.setLayout(vlayout)