Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix race condition between Sync and Apply actions #49

Open
spyglass-software opened this issue Mar 13, 2023 · 0 comments
Open

Fix race condition between Sync and Apply actions #49

spyglass-software opened this issue Mar 13, 2023 · 0 comments
Labels
reliability Reliability and stability related issues wontfix This will not be worked on

Comments

@spyglass-software
Copy link
Contributor

We need to address the various ways that sync and apply commands can collide.

Scenario: Sync Occurs Before Apply Completion

  1. Git push lands with an update such as roleGrants.finance_viewer.select.view = ["acme.prod.payments"]
  2. The Apply action runs and prepares to execute grant select on view acme.prod.payments to role finance_viewer;
  3. The Sync action runs, and, not seeing any role grants for finance_viewer, it deletes the recent line from the yaml and commits.
  4. The Apply action continues and executes the grants in Snowflake.

Result: finance_viewer has grants in Snowflake but not in YAML. This will be resolved at the next Sync, but causes an unexpected user experience.

@spyglass-software spyglass-software added the reliability Reliability and stability related issues label Mar 13, 2023
@spyglass-software spyglass-software added the wontfix This will not be worked on label Mar 27, 2023
@spyglass-software spyglass-software removed this from the v0.2 Beta Release milestone Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reliability Reliability and stability related issues wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant