Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.Clone() doesn't set the correct parents for children. #73

Closed
yevgenin opened this issue Sep 2, 2024 · 1 comment
Closed

Node.Clone() doesn't set the correct parents for children. #73

yevgenin opened this issue Sep 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@yevgenin
Copy link
Contributor

yevgenin commented Sep 2, 2024 •
edited
Loading

The parent fields of children after a clone, still point to the original nodes, not the cloned ones. I wonder if this was intended? Anyway I propose a fix. See a PR I opened. #74

Also thank you for this great lib! Very useful.
@yevgenin yevgenin mentioned this issue Sep 2, 2024
Merged
@spyzhov
Copy link
Owner

spyzhov commented Sep 3, 2024

Thanks! Looks catch, it was a bug :-) merged 👍

@spyzhov spyzhov closed this as completed Sep 3, 2024
@spyzhov spyzhov added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yevgenin @spyzhov