Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init #1

Closed
4kimov opened this issue Jul 28, 2023 · 14 comments
Closed

Init #1

4kimov opened this issue Jul 28, 2023 · 14 comments
Labels
help wanted Extra attention is needed

Comments

@4kimov
Copy link
Member

4kimov commented Jul 28, 2023

Hey @fanweixiao / @0x3333, Sqids is live, would you like to give this implementation a shot?

@fanweixiao
Copy link

Hi @4kimov, working on the first impl, hope will push in next week.

@4kimov
Copy link
Member Author

4kimov commented Jul 28, 2023

Right on 💪 Let me know if you have questions/etc

@0x3333
Copy link
Collaborator

0x3333 commented Jul 28, 2023

Hi @4kimov, working on the first impl, hope will push in next week.

Which minimum java version will be supported?

@4kimov
Copy link
Member Author

4kimov commented Aug 9, 2023

@fanweixiao How's it going with this repo?

@4kimov 4kimov added the help wanted Extra attention is needed label Aug 23, 2023
@lukechen116
Copy link
Collaborator

Hello @4kimov, I implemented Java code for Sqids. I would like to contribute this code and upload branch. How do I provide?

@4kimov
Copy link
Member Author

4kimov commented Oct 5, 2023

Hi @lukechen116, nice - thank you & good job 👍 Sent you an invite to be a maintainer. Feel free to remove the CHANGELOG, release package, etc

I'll update the site shortly.

Edit: Btw, in the README examples, are there missing semicolons at the end of encode/decode lines or is it meant to be this way?

@4kimov 4kimov closed this as completed Oct 5, 2023
@lukechen116
Copy link
Collaborator

@4kimov I changed constructor to Gang of Four (GoF) design Builder pattern that is friendly readable code and constructor default parameters are reduced. Would you update official site example code?

@4kimov
Copy link
Member Author

4kimov commented Oct 11, 2023

@lukechen116 No problem, updated. Let me know if anything else needs adjusting.

  1. Could we have Github Actions to auto-test on push, like the other repos?
  2. I'm guessing CHANGELOG is not common in Java packages, should we remove that file?

@lukechen116
Copy link
Collaborator

@4kimov Thank you.

  1. Setup completed. This is my first time using GitHub Actions, so it took a little longer. Sorry for the delay.
  2. CHANGELOG doesn't affect the Java project or packages. I'm keeping it for future use.

@4kimov
Copy link
Member Author

4kimov commented Oct 12, 2023

@lukechen116 Perfect, thank you 👍

@lukechen116
Copy link
Collaborator

Hello @4kimov / @fanweixiao / @0x3333
I have tested it almost.
Could you assist me to package and publish it to the Maven repository for public use?

@fanweixiao
Copy link

Hi @lukechen116, the maven repository is maintained by @0x3333, he will help in this. But he's got busy these days.

@0x3333
Copy link
Collaborator

0x3333 commented Oct 17, 2023

I'll issue a PR with the settings to Gradle to allow publishing to the Maven repo. I'll ask for some time, as things are really stacking up here.

@lukechen116
Copy link
Collaborator

@0x3333 / @fanweixiao, thank you for all the help! Please let me know if anything else is needed or suggested.
@4kimov Could you invite @0x3333 to be the maintainer for this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants