Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create consumer proguard rules #18

Closed
almozavr opened this issue Sep 6, 2023 · 2 comments
Closed

Create consumer proguard rules #18

almozavr opened this issue Sep 6, 2023 · 2 comments

Comments

@almozavr
Copy link

almozavr commented Sep 6, 2023

Issue

By default sqlcipher-android doesn't support Proguard, so andorid's R8 rips out valuable information, e.g.

 no "Ljava/lang/String;" field "name" in class "Lnet/zetetic/database/sqlcipher/SQLiteCustomFunction;" or its superclasses

Solution

Add consumer-rules.pro to the project, so it's included in aar.

P.S.
Currently we use this, but probably it's an overkill

-keep,includedescriptorclasses class net.zetetic.database.** { *; }
-keep,includedescriptorclasses interface net.zetetic.database.** { *; }
@developernotes
Copy link
Member

Hi @almozavr,

Sorry for the late reply, this is a good idea. Would you be interested in submitting a pull request for this? If so, we have a contributor license agreement 1. Please reach out to us at support@zetetic.net.

Footnotes

  1. https://www.zetetic.net/contributions/

@eygraber
Copy link
Contributor

This was addressed by #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants