Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning columns in Insert / Update clauses #372

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dgadelha
Copy link

@dgadelha dgadelha commented May 10, 2020

Implements an argument in Insert/Update-clauses related functions to allow returning columns directly through SQL

Compatibility:

  • PostgreSQL
  • MSSQL

A generic function was created to allow RDBMS-specific compilers (in this case, PostgreSQL and MSSQL) to handle special cases like this.

Fixes #8

@dgadelha dgadelha marked this pull request as ready for review May 10, 2020 10:09
@b-twis
Copy link
Contributor

b-twis commented Jun 8, 2020

@dgadelha Would it be possible to extend this to also cover delete queries as requested in #133

@ahmad-moussawi Would be fantastic to get this merged as I currently have to code up and run select queries after each of the insert/updates.

@b-twis
Copy link
Contributor

b-twis commented Jun 12, 2020

@ahmad-moussawi I guess the only blocker here would be to address the merge conflicts?

@dgadelha
Copy link
Author

@b-twis once the package maintainer shows up ensuring this PR will get some attention, I can do that

It's been a month since it was opened and no review. I can do what you asked but I need to make sure I won't waste my time

@BrianPainter88
Copy link

Is there any update to this particular request? This would be an amazing addition to this package.

@b-twis
Copy link
Contributor

b-twis commented Sep 26, 2020

@ahmad-moussawi Would it be possible for you to find time to review this change?

@graknol
Copy link

graknol commented Nov 17, 2020

Bumpy bump 🛺.

@ianclegg
Copy link

What needs to be done to move this PR forward?

@ahmad-moussawi
Copy link
Contributor

@ianclegg the PR have conflicts with the master branch

@ahmad-moussawi ahmad-moussawi force-pushed the master branch 7 times, most recently from 838f8ca to 47633a3 Compare March 14, 2021 14:51
@aamcatamney
Copy link

Bump

@zh6335901
Copy link

When will the PR be merged?

@d-chirkov
Copy link

Bump

@ahmad-moussawi ahmad-moussawi force-pushed the master branch 2 times, most recently from 748c2bf to bad6733 Compare June 12, 2021 03:48
@aamcatamney
Copy link

Bump


if (returnColumns.Count > 0)
{
const string prefix = "inserted.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be times when a person wants the deleted columns as well.

@iulian0512
Copy link

bump

@deg-mallard
Copy link

Are there any plans to finish these changes and merge into the master?

@JakeAlmer
Copy link

This looks great, wonder if this will ever get merged?

@EricNgo1972
Copy link

Another upvote for merging this PR. This feature is crucial.

@jonnysmith1981
Copy link

It's over 4 years now since this PR was first opened. As others have asked above, what needs to be done to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning clause