-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow returning columns in Insert / Update clauses #372
base: master
Are you sure you want to change the base?
Conversation
this allows RDBMS-specific compilers to handle special cases like returning clause
@dgadelha Would it be possible to extend this to also cover delete queries as requested in #133 @ahmad-moussawi Would be fantastic to get this merged as I currently have to code up and run select queries after each of the insert/updates. |
@ahmad-moussawi I guess the only blocker here would be to address the merge conflicts? |
@b-twis once the package maintainer shows up ensuring this PR will get some attention, I can do that It's been a month since it was opened and no review. I can do what you asked but I need to make sure I won't waste my time |
Is there any update to this particular request? This would be an amazing addition to this package. |
@ahmad-moussawi Would it be possible for you to find time to review this change? |
Bumpy bump 🛺. |
What needs to be done to move this PR forward? |
@ianclegg the PR have conflicts with the master branch |
838f8ca
to
47633a3
Compare
Bump |
When will the PR be merged? |
Bump |
748c2bf
to
bad6733
Compare
Bump |
|
||
if (returnColumns.Count > 0) | ||
{ | ||
const string prefix = "inserted."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be times when a person wants the deleted
columns as well.
bump |
Are there any plans to finish these changes and merge into the master? |
This looks great, wonder if this will ever get merged? |
Another upvote for merging this PR. This feature is crucial. |
It's over 4 years now since this PR was first opened. As others have asked above, what needs to be done to get this merged? |
Implements an argument in Insert/Update-clauses related functions to allow returning columns directly through SQL
Compatibility:
A generic function was created to allow RDBMS-specific compilers (in this case, PostgreSQL and MSSQL) to handle special cases like this.
Fixes #8