Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade stdlib to Kotlin 1.4 #52

Closed
zach-klippenstein opened this issue Aug 20, 2020 · 3 comments
Closed

Upgrade stdlib to Kotlin 1.4 #52

zach-klippenstein opened this issue Aug 20, 2020 · 3 comments

Comments

@zach-klippenstein
Copy link
Collaborator

This was initially done in #45, but then was reverted in #51 to support older consumers for now. We will probably upgrade to 1.4 after the 2.0.0 release.
@zach-klippenstein
Copy link
Collaborator Author

Apparently our ktlint plugin can be configured to use a different ktlint version: JLLeitschuh/ktlint-gradle#383

@zach-klippenstein
Copy link
Collaborator Author

We're now building with 1.4, but still depending on the stdlib from 1.3 for compatibility with consumers who haven't upgraded.

@zach-klippenstein zach-klippenstein changed the title Upgrade to Kotlin 1.4 Upgrade stdlib to Kotlin 1.4 Sep 3, 2020
@zach-klippenstein
Copy link
Collaborator Author

Quoth @pyricau:

shouldn’t we just close it?
ie is there really any reason to upgrade the stdlib any time soon?
1.4 was just out so forcing this would be a blocker to adoption for a large number of consumers
on the espresso side we’ll likely have an API that lets us autoload
which means you just add the radiography and immediately get nice views in espresso. Should facilitate adoption! but only if we don’t have any direct dependency that blocks adoption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zach-klippenstein