Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not use info logging level from docker image #934

Closed
dpordomingo opened this issue Jul 19, 2019 · 1 comment · Fixed by #935
Closed

Can not use info logging level from docker image #934

dpordomingo opened this issue Jul 19, 2019 · 1 comment · Fixed by #935

Comments

@dpordomingo
Copy link
Contributor

caused by https://github.com/src-d/sourced-ce/issues/142

Under the context UX on source{d} CE, I'm reviewing its logs (to make them as simple as possible, to be understandable for the user), and I saw that for gitbase, is not possible to use debug level info (info, which is the default for gitbase, is the only one failing, the others are not)

I found that it's because the verbose mode is enabled in the init.sh, so when using gitbase docker image, the debug level is set from the beginning by server.go:131, and since it was passed info to the command (the default), it is not recovered because of the if at server.go:140

If it is requested any other log level, the if at server.go:140 will let that the desired log level is used.

@dpordomingo dpordomingo changed the title When using docker image, info log level cannot be used From docker image, info log level cannot be used Jul 19, 2019
@dpordomingo
Copy link
Contributor Author

proposed solution:
#935

@dpordomingo dpordomingo changed the title From docker image, info log level cannot be used Can not use info logging level from docker image Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant