*: windows support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 89.14% 89.22% +0.08%
==========================================
Files 6 6
Lines 433 427 -6
==========================================
- Hits 386 381 -5
Misses 27 27
+ Partials 20 19 -1
Continue to review full report at Codecov.
|
ajnavarro
reviewed
Apr 17, 2017
| @@ -33,7 +33,7 @@ func (s *subdirFs) Create(filename string) (billy.File, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| return newFile(f, filename), nil | |||
| return newFile(s, f, filename), nil | |||
There was a problem hiding this comment.
Maybe this logic inside the newFile method (filename = fs.Join(fs.Base(), filename)) should be outside. Then the newFile method can only receive a billy.File and a path.
There was a problem hiding this comment.
but then you need to copy paste the same line three times
smola
approved these changes
Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows support review