Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

crossJoinIterator is not using contexts, so queries cannot be cancelled. #292

Closed
ajnavarro opened this issue Jul 17, 2018 · 1 comment
Closed

crossJoinIterator is not using contexts, so queries cannot be cancelled. #292

ajnavarro opened this issue Jul 17, 2018 · 1 comment
Assignees
@erizocosmico
Labels
bug Something isn't working

Comments

@ajnavarro
Copy link
Contributor

Make it use context to be able to stop queries using joins.
@ajnavarro ajnavarro added the bug Something isn't working label Jul 17, 2018
@erizocosmico erizocosmico self-assigned this Jul 17, 2018
@erizocosmico
Copy link
Contributor

I can't reproduce this. Cross join iterator uses context all over the place and passes it down to all other nodes, so there's not any other place where it should be passed.

I also tried in gitbase and the query could be cancelled perfectly fine.

@erizocosmico erizocosmico mentioned this issue Jul 18, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erizocosmico erizocosmico

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajnavarro @erizocosmico