Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Collect session warnings #465

Closed
kuba-- opened this issue Oct 17, 2018 · 1 comment
Closed

Collect session warnings #465

kuba-- opened this issue Oct 17, 2018 · 1 comment
Assignees
@erizocosmico
Labels
enhancement New feature or request

Comments

@kuba--
Copy link
Contributor

kuba-- commented Oct 17, 2018

After we implemented SHOW WARNINGS, right now we need to collect to session warnings.
PR: #464 extended Session interface by:

  • AppendWarning(warn *sql.Warning)
  • Warnings()[]*sql.Warning
    So, what left is to collect session warnings and call ctx.Session.AppendWarning(...)

Related to:
@kuba-- kuba-- added the enhancement New feature or request label Oct 17, 2018
@kuba-- kuba-- mentioned this issue Oct 17, 2018
Merged
@erizocosmico
Copy link
Contributor

AppendWarning is perhaps too specific to how it's implemented. How about AddWarning or just Warn?

@erizocosmico erizocosmico self-assigned this Oct 19, 2018
@erizocosmico erizocosmico mentioned this issue Oct 19, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erizocosmico erizocosmico

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erizocosmico @kuba--