Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter social preview #468

Closed
Tracked by #175 ...
srid opened this issue Dec 6, 2023 · 5 comments · Fixed by #499
Closed
Tracked by #175 ...

Twitter social preview #468

srid opened this issue Dec 6, 2023 · 5 comments · Fixed by #499
Labels
enhancement New feature or request HTML Templates Emanote's builtin HTML templates

Comments

@srid
Copy link
Owner

srid commented Dec 6, 2023

https://socialsharepreview.com/?url=https://nixos.asia/en/direnv =>

image
@srid srid added enhancement New feature or request HTML Templates Emanote's builtin HTML templates labels Dec 6, 2023
@srid srid mentioned this issue Dec 6, 2023
12 tasks
@srid srid pinned this issue Dec 6, 2023
@srid
Copy link
Owner Author

srid commented Dec 8, 2023

And what's going on here with the broken image render:

image

@shivaraj-bh
Copy link
Collaborator

shivaraj-bh commented Dec 20, 2023

og:image does work even on twitter, according to the developer guidelines, they do fallback to og:image if there are no tags that twitter supports. You can see that in action here: https://socialsharepreview.com/?url=https://docusaurus.io/docs/blog

And since we already support og:image meta tag after this PR, we should see the image render, i.e if we have a regular URL on the page.

Regarding the broken image render above, it might be because there is a meta tag with empty content.
Screenshot 2023-12-20 at 8 07 20 PM

Maybe we could have a default image set in index.yaml as a fallback for every page.

@srid
Copy link
Owner Author

srid commented Dec 20, 2023

Ah, so basically we need to address this FIXME then:

image

https://github.com/srid/emanote/pull/297/files#diff-08d291239412fde72df0c777f60d24bd5a0f802a1a8dde42e80e40499af7fabcR277-R278

That's why the image in https://nixos.asia/en/tutorial/nixos-install is not showing up.

@srid
Copy link
Owner Author

srid commented Jan 17, 2024

Preview is super bad. The 'description' itself is messed up. I will take a look.

image

@srid
Copy link
Owner Author

srid commented Jan 19, 2024

#499 addresses this, but you still have to explicitly specify the image URL in page.image YAML property.

@srid srid closed this as completed in #499 Jan 19, 2024
@srid srid unpinned this issue Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HTML Templates Emanote's builtin HTML templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants