Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task list checkbox styling is bad #233

Closed
srid opened this issue Jun 13, 2020 · 5 comments
Closed

Task list checkbox styling is bad #233

srid opened this issue Jun 13, 2020 · 5 comments
Labels
good first issue Good for newcomers Web Interface UI related

Comments

@srid
Copy link
Owner

srid commented Jun 13, 2020

This:

- [ ] Foo
- bar
- baz
- [ ] Foo 2
- bar

produces list items with differing margins:
ink

@srid srid added good first issue Good for newcomers Web Interface UI related labels Jun 13, 2020
@srid
Copy link
Owner Author

srid commented Jul 25, 2020

Need to fix the checkbox right margin as well:

image

@srid srid changed the title GFM task lists are not aligned properly Task list checkbox styling is bad Jul 25, 2020
@srid
Copy link
Owner Author

srid commented Jul 26, 2020

Okay, so the original issue -- of producing list items with differing margins -- is because Pandoc creates a new list AST where you start or stop using task lists. Apparently Pandoc considers a task list to be a single list only if all items in it contains the checkbox. So neuron will treat it as a limitation of Pandoc and mark it as "wontfix".

However the alignment issue mentioned in the comment above is fixed in 0b36bd8 via srid/reflex-dom-pandoc@d40dedc

image

@srid srid closed this as completed Jul 26, 2020
@dariusf
Copy link

dariusf commented Sep 9, 2020

There seems to have been a regression here (development version from yesterday).
Screenshot 2020-09-09 at 12 37 14 PM
Adding vertical-align: middle; to the surrounding div is one way to fix this.

@srid
Copy link
Owner Author

srid commented Sep 11, 2020

@dariusf I can't reproduce. If you can, open a new issue pasting the Zettel markdown that triggers this.

@dariusf
Copy link

dariusf commented Sep 11, 2020

Right, it's a Firefox thing... opened an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Web Interface UI related
Projects
None yet
Development

No branches or pull requests

2 participants