Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cron execution #3

Closed
thewtex opened this issue Mar 24, 2020 · 5 comments
Closed

Support cron execution #3

thewtex opened this issue Mar 24, 2020 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@thewtex
Copy link

thewtex commented Mar 24, 2020

Thanks for implementing and sharing this nice Action 🙏 👏

Currently, the action will fail on forked pull requests per the GitHub Action permission limitations:

Could it be possible to run in a scheduled mode, i.e. cron, by examining open pull requests and labelling them?

Or, not fail when the required permissions are not available?

@srvaroa
Copy link
Owner

srvaroa commented Mar 25, 2020

Thanks @thewtex! I will look into both points, not failing when perms are not available should be pretty quick but having the option to use the scheduled mode seems a better solution overall.

In the meantime PRs are of course welcome :)

@srvaroa
Copy link
Owner

srvaroa commented Mar 26, 2020

The first part should be done, the action will always succeed, but log an error if something failed in the process.

I'll look into the cron next.

@thewtex
Copy link
Author

thewtex commented Mar 27, 2020

@srvaroa awesome, thank you!! 🙏

@srvaroa
Copy link
Owner

srvaroa commented Mar 23, 2021

@thewtex this one should be addressed by #26

@srvaroa
Copy link
Owner

srvaroa commented Apr 24, 2021

Supported from v0.7, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants