Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer API V2 when a CA directory offers both #690

Closed
tlhackque opened this issue Jul 30, 2021 · 2 comments · Fixed by #691
Closed

Prefer API V2 when a CA directory offers both #690

tlhackque opened this issue Jul 30, 2021 · 2 comments · Fixed by #691

Comments

@tlhackque
Copy link
Contributor

When working on Apache httpd's mod_md last year, I ran into a CA (name escapes me at the moment) that offers API V1 and V2 in the same directory. (At the same URL.) Since API V1 is deprecated/obsolete, getssl should choose V2 in this case.

Looks like a trivial change - I'll push a patch to my repo, but it could use a test.

@tlhackque
Copy link
Contributor Author

The CA is BuyPass.

Here's their unified directory case (formatted for readability) - note that the directory has both new-reg and newAccount:

https://api.buypass.com/acme/directory

{"new-reg":"https://api.buypass.com/acme/new-reg",
 "new-cert":"https://api.buypass.com/acme/new-cert",
 "new-authz":"https://api.buypass.com/acme/new-authz",
 "revoke-cert":"https://api.buypass.com/acme/revoke-cert",
 "key-change":"https://api.buypass.com/acme/key-change",
 "meta":{"website":"https://buypass.com/",
 "caa-identities":["buypass.com"],
 "terms-of-service":"https://api.buypass.com/acme/terms/750",
 "caaIdentities":["buypass.com"],
 "termsOfService":"https://api.buypass.com/acme/terms/750"},
 "newNonce":"https://api.buypass.com/acme-v02/new-nonce",
 "newAccount":"https://api.buypass.com/acme-v02/new-acct",
 "newAuthz":"https://api.buypass.com/acme-v02/new-authz",
 "newOrder":"https://api.buypass.com/acme-v02/new-order",
 "revokeCert":"https://api.buypass.com/acme-v02/revoke-cert",
 "keyChange":"https://api.buypass.com/acme-v02/key-change"
}

Documentation: https://community.buypass.com/t/63d4ay/buypass-go-ssl-endpoints-updated-14-05-2020

@tlhackque
Copy link
Contributor Author

I added a test for this to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant