Not module friendly

[ndugger]

It's interesting that you used java to write this, but it's 100% not JS module friendly. At this current moment, I have to fork this and frankenstein the JS output in order to import it into my project.

If you'd be willing to explore making the javascript output more modern, that would be fantastic.

I'd like to be able to use it as such:

import EditControl from 'babylonjs-editcontrol';

which, with the help of Babel, transpiles to:

var EditControl = require('babylonjs-editcontrol');

You would also have to make your editcontrol import babylon, otherwise I ran into dependency issues with the way that you're grabbing values from BABYLON, because I also import babylon from npm (they have their own module).

I have no idea how you'd finagle the java to allow for something like this, but I can definitely help with the javascript side of things.

I can translate your Java into the new JS syntax (classes, modules, etc) if you'd like. Let me know. I can knock that out in a few hours, probably.

[ndugger]

I went ahead and did a 1:1 translation here: https://github.com/ndugger/babylonjs-editcontrol-js

There's a lot that can be improved in the logic and flow, so that's my next plan. Let me know what you think. I'd love to collaborate on this.

[ssatguru]

Hi Nick,
On vacation now
Will get back to you soon.
Regards
Satguru

On Sat, Mar 12, 2016 at 6:13 PM, Nick Dugger notifications@github.com
wrote:

I went ahead and did a 1:1 translation here:
https://github.com/ndugger/babylonjs-editcontrol-js

There's a lot that can be improved in the logic and flow, so that's my
next plan. Let me know what you think. I'd love to collaborate on this.

—
Reply to this email directly or view it on GitHub
ssatguru/BabylonJS-EditControl#1 (comment)
.