Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some word that may be worth adding to dictionaries #590

Closed
maverick74 opened this issue Aug 1, 2024 · 8 comments · Fixed by #584
Closed

Some word that may be worth adding to dictionaries #590

maverick74 opened this issue Aug 1, 2024 · 8 comments · Fixed by #584
Labels
languages Dictionary or language related issues

Comments

@maverick74
Copy link

As mentioned previously (in #472 ), here's a file with some words that you may think are worth to add to dictionaries (english/portuguese).

I'll leave them into you consideration, naturally! (you may not even add anything)

File is in CSV but i've added some descriptions in columns C and D to help you evaluate it.
C, mostly, is the "type" of word and may help you filter what you want to add (if you want to add anything at all)

tt9-added-words-export--1722510988672.csv

You can close this at anytime :)

thank you!!!

@sspanak
Copy link
Owner

sspanak commented Aug 2, 2024

Excellent! This is exactly the help I am looking for. I believe all words are good for adding, I just would like to make some corrections:

  • gnome - already available in English
  • hotmail -> Hotmail
  • speccy -> Speccy
  • rss -> RSS
  • bulling -> did you mean "bullying"? Otherwise, I didn't even know "bulling" exists. Is it really a common word?
  • gitlab -> GitLab
  • iphone -> iPhone
  • olx -> OLX
  • suv -> SUV (if you are referring to the big cars)
  • You have added Elon to English, but Musk to Portuguese. I'll add the entire name to both languages, in case some part is missing.
  • On my side, I found that the name "Al" is missing from English, so I'll add it too.

@sspanak sspanak added the languages Dictionary or language related issues label Aug 2, 2024
@maverick74
Copy link
Author

bulling -> did you mean "bullying"?

yeah, it's "bullying"... (i've eat the "Y" at breakfast ahahahaha)

I've added that one wrongly!!! it's already present in english and portuguese, so you can forget about it!

Is it really a common word?

Yeah... it's pretty common here, now. Almost anything is bullying these days!!! You almost can't say a joke without someone complaining.............. I'm just over 40 but i really feel i did grow up in a completely different world, sometimes!!!

@sspanak sspanak linked a pull request Aug 7, 2024 that will close this issue
@sspanak
Copy link
Owner

sspanak commented Aug 7, 2024

I have added all the English and Portuguese words, including some extra ones that came to my mind, e.g. seeing "Nokia" and "Samsung", I figured out it would be nice to add "Apple", "Xiaomi" and "Huawei", too. They are also extremely popular.

I'll keep the issue and the pull request open until before the release, in case I find more words are missing. It is more convenient to me this way.

Yeah... it's pretty common here, now. Almost anything is bullying these days!!! You almost can't say a joke without someone complaining.............. I'm just over 40 but i really feel i did grow up in a completely different world, sometimes!!!

I'm just below 40 and I feel the same sometimes. Fortunately, we are still keeping strong on the Balkans and we don't get offended for no reason. At least not all the time.

@maverick74
Copy link
Author

I'm just below 40 and I feel the same sometimes. Fortunately, we are still keeping strong on the Balkans and we don't get offended for no reason. At least not all the time.

Yeah, my "generation" doesn't get offended for nothing either! But new generations - here -seem to (at least the people I talk too)!
It's "the world moving on"...

I'll keep the issue and the pull request open until before the release

I've also came across more 2 or 3 that are capitalized (the first letter) but I was in a hurry and didn't save them...

@sspanak
Copy link
Owner

sspanak commented Aug 15, 2024

@maverick74, there is one more thing you could do to help improving Portuguese, if you will. You have used the language a lot, so the word priorities must have improved in comparison to the defaults from Google that I got. If you export them, I will update the main dictionary, so everybody will get better suggestion order right from the start. And this includes you, too, because with the new words you suggested for v37.0, you will have to reload Portuguese, which will reset the priorities to the defaults.

You can export the factory words with their priorities like this:

  1. Open the Settings
  2. Click the version information to access the Debug Screen.
  3. Change the "Log Level" to "Debug".
  4. Go to "Languages".
  5. Disable all but Portuguese
  6. Click the newly appeared "Export Selected". It should be the third option from the top. After exporting is done the CSV will appear either in the "Documents" or the "Download" folder of your phone.
  7. Open the file and remove the custom added words at the end. They will probably be around line 643487, after the word "pneumoultramicroscopicossilicovulcanoconiótico". You will recognize them, because they will not conform the ordering by length. This step is not mandatory, I will remove them anyway. Do it only if you are worried about sharing the words publicly.
  8. Upload the exported .csv here or send it by e-mail.

After you are done, do not forget to re-enable the languages you were using previously and changing the "Log Level" to "Error" again. Keeping it at "Debug" will cause TT9 to run a bit slower and use a lot of storage space.

Also, note that exporting may take several minutes. It is something like loading a dictionary, but no progress is reported, so will just have to wait a bit for it to finish. You are not required to keep TT9 open, you can do something else on your phone, or even leave it on the table and do other stuff.

@maverick74
Copy link
Author

maverick74 commented Aug 20, 2024

sorry, it's a bit late (i know) but there is no hurry either.

I've been away (kind of) and just now was able to get the exported file. i don't seem to find an e-mail address to send it to you...

@sspanak
Copy link
Owner

sspanak commented Aug 20, 2024

i don't seem to find an e-mail address to send it to you...

It's listed on Google Play, but apparently, you are not using it 🙂. It's ddimo@proton.me. It's also OK, to upload the file here, whatever works for you.

sorry, it's a bit late (i know) but there is no hurry either.

It's OK, as long as you have exported it before upgrading to v37.0. You still haven't reloaded the dictionary, so the priorities are not reset. And I can include them in any future version, it doesn't have to be 37.0 indeed.

@maverick74
Copy link
Author

sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
languages Dictionary or language related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants