Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Error with Jalali Calendar Option in dayjs #1

Closed
erfanfarhadi75 opened this issue Aug 12, 2024 · 2 comments · Fixed by #2
Closed

Configuration Error with Jalali Calendar Option in dayjs #1

erfanfarhadi75 opened this issue Aug 12, 2024 · 2 comments · Fixed by #2
Assignees
Labels
typescript typescript issue

Comments

@erfanfarhadi75
Copy link

erfanfarhadi75 commented Aug 12, 2024

image

I encountered an issue when trying to use the Jalali calendar with the dayjs library. It appears that the jalali option is not recognized in the configuration object, which results in TypeScript errors.
I was using the @zoomit/dayjs-jalali-plugin without encountering any errors like this.

"dayjs": "^1.11.12",
"jalali-plugin-dayjs": "^1.1.3",
"@angular/core": "^17.1.1",
"typescript": "^5.2.2"

image

Although I bypassed it as shown below, it works fine.

image

@sssajjad007 sssajjad007 added the typescript typescript issue label Aug 12, 2024
@sssajjad007 sssajjad007 linked a pull request Aug 12, 2024 that will close this issue
@sssajjad007 sssajjad007 self-assigned this Aug 12, 2024
@sssajjad007
Copy link
Owner

Hi @erfanfarhadi75
This issue has been fixed in this PR.
feel free to reopen it.

@erfanfarhadi75
Copy link
Author

Hi @sssajjad007
Thank you for the update! I appreciate you taking the time to address the issue. I'll review the changes, and if there's anything further needed, I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript typescript issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants