Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Revisons cannot be saved properly #745

Closed
tk166 opened this issue Sep 22, 2023 · 6 comments
Closed

[BUG] Revisons cannot be saved properly #745

tk166 opened this issue Sep 22, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@tk166
Copy link

tk166 commented Sep 22, 2023

Describe the bug
If revise a multiline card when do space repetitions, The New revised contents will not be at the desired locations but will be place after the meta data.

To Reproduce
Steps to reproduce the behavior:

  1. Create a multiline card (with self defined separator ++)
  2. Review the card in space repetition.
  3. Revise the card by the revision button on the card and save.
  4. Find that the revisions won't work.

Expected behavior
Revisions are expected to be saved properly.

Screenshots
Revision example
p1
Improper revision reult example
p2

Versions (please complete the following information):

  • OS: Windows10 & Linux Mint 20.04
  • Obsidian version: v1.4.13
  • Plugin version: 1.10.1

Additional context
Self defined separator was set ++ and +++ to make it easy to type these marks without switching the input methods between English and Simplified Chinese frequently, because different question marks (? and ) or other marks are adopted in them.

@tk166 tk166 added the bug Something isn't working label Sep 22, 2023
@ronzulu
Copy link
Collaborator

ronzulu commented Sep 23, 2023

Hello

And just checking, before the card was edited, it started off as:

Test Card
++
Answer 1

@tk166
Copy link
Author

tk166 commented Sep 24, 2023

Hello

And just checking, before the card was edited, it started off as:

Test Card
++
Answer 1

Yes, That's the original card

@ronzulu
Copy link
Collaborator

ronzulu commented Sep 30, 2023

Hi

This has been fixed in a Beta release at:
https://github.com/ronzulu/obsidian-spaced-repetition/releases/tag/1.11.0-beta.0

If you would like to use it, you would need to manually download a couple of files as described in the release note.

Cheers
Ronny

@tk166
Copy link
Author

tk166 commented Sep 30, 2023

Thanks for your hard work and the fixes works well.

@ronzulu
Copy link
Collaborator

ronzulu commented Oct 2, 2023

Great, thanks for letting me know.

@ronzulu
Copy link
Collaborator

ronzulu commented Oct 10, 2023

Hi @tk166

The fix for this has been included in the latest release 1.10.2.

Please update to the latest version of the plug-in, and if all good, close off this issue report.

Cheers
Ronny

@tk166 tk166 closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants