-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube Embeds with specified timestamps no longer being obeyed after updating [BUG] #817
Comments
Hi @nayyala, it would be helpful if you attach a Cheers |
Here it is: |
I tried perhaps 10 times in total, but couldn't reproduce. I've tried: Work.Vault->flashcard-> play clip-> cancel from modal What platform are you using? During the #751 restructure, I didn't change any of the possibly related code, so unlikely I can assist with this one. e.g. I didn't change |
Was there any non-OSR plug-in system changes recently? If you temporarily revert to 1.10.1 does this work reliably? |
Well, it would appear that the issue is not related to the plugin at all. I have removed the plugin entirely and the issue persists. Something is going wrong with YouTube timestamps in the iframe embed. Apologies. |
I did learn something from this... I never would have thought of embedding video within a question! |
Describe the bug
YouTube timestamps in iframe embeds from flashcards are completely ignored. It jumps to the timestamp and then completely switches elsewhere
To Reproduce
Steps to reproduce the behavior:
Try making a flashcard with the following embed:
<iframe width="560" height="315" src="https://www.youtube.com/embed/Lg5P2w_Ro1c?start=1135&end=1147&autoplay=0&random=1234" frameborder="0" autoplay="1" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"></iframe>It will not start at the desired timestamp. It almost gets there, but immediately jumps elsewhere. If you have never seen the video before, maybe it will but after a handful of times, try jumping to another part and then watch it disobey.
Expected behavior
As in the previous versions, I was able to have a youtube video within an iframe load at a the specified timestamp and finish at the specified end stamp. However, the video simply begins from the last point it was accessed completely ignoring it.
Screenshots
If applicable, add screenshots to help explain the bug. This could be the logs in the developer console (
CTRL
+SHIFT
+i
).Versions (please complete the following information):
Spaced Repetition v 1.10.5
Obsidian 1.4.16
Additional context
Add any other context about the problem here (e.g. the markdown producing the error).
The text was updated successfully, but these errors were encountered: