Add orbit state vectors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering whether they schould generally be externalized to keep things small? Just thinking out loud right now. |
m-mohr
reviewed
Jul 22, 2024
|
Validation fails with STAC Node Validator while it works fine with this tool: https://jsonschema.dev/ |
m-mohr
reviewed
Jul 22, 2024
json-schema/schema.json
Outdated
| "type": "object", | ||
| "$comment": "The key is a date-time string, and the value is an array of numbers.", | ||
| "patternProperties": { | ||
| "^([\\+-]?\\d{4}(?!\\d{2}\b))((-?)((0[1-9]|1[0-2])(\\3([12]\\d|0[1-9]|3[01]))?|W([0-4]\\d|5[0-2])(-?[1-7])?|(00[1-9]|0[1-9]\\d|[12]\\d{2}|3([0-5]\\d|6[1-6])))([T\\s]((([01]\\d|2[0-3])((:?)[0-5]\\d)?|24\\:?00)([\\.,]\\d+(?!:))?)?(\\17[0-5]\\d([\\.,]\\d+)?)?([zZ]|([\\+-])([01]\\d|2[0-3]):?([0-5]\\d)?)?)?)?$": { |
There was a problem hiding this comment.
Various comments:
- The
\bmight cause the issue with esacping in the node validator. Try\\b. - STAC generally requires
Z/UTC as timezone so we can probably simplify from([zZ]|([\\+-])([01]\\d|2[0-3]):?([0-5]\\d)?)?to([zZ])? - What is this part about:
W([0-4]\\d? I've never ween a W in ISO date-times. I guess that's forW([0-4]\\d, which is not valid here.
|
Before we get too deep into regexes: Would it be good enough to just define a relation type? Is state vectors something that you'd search for? I don't quite like embedding these "big" constructs to STAC such as state vectors, histograms, etc. |
|
Do you have any updates on this PR? |
m-mohr
reviewed
Oct 7, 2024
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
|
@emmanuelmathot Any updates on the open comments ;-) |
m-mohr
reviewed
Dec 11, 2024
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
m-mohr
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to provides with orbit state vectors either inline or with a linked file.
It fixes #3