Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: pre-commit hooks for QA tasks #366

Closed
l0b0 opened this issue May 27, 2021 · 3 comments
Closed

RFC: pre-commit hooks for QA tasks #366

l0b0 opened this issue May 27, 2021 · 3 comments

Comments

@l0b0
Copy link
Contributor

l0b0 commented May 27, 2021

Would you be interested in some simple configuration to automatically run flake8, yapf, mypy etc. when committing files? I've already set up pre-commit in another few projects, and it's super helpful:

  • No need to manually run standard QA commands before checking in.
  • Checks only the files you're committing at that point, so it's fast.
  • Can tie straight into the binaries installed from requirements-dev.txt.
  • Can also be run in the CI pipeline, making for a simpler CI script which just runs pre-commit run --all-files to run all the checks.
  • Runs all the checks even if some of them fail and then reports the exit code, so you'd get more information than the current build script.
@duckontheweb duckontheweb mentioned this issue Jun 1, 2021
4 tasks
@vincentsarago
Copy link
Member

is this the same issue as #390 @l0b0 ?

@l0b0
Copy link
Contributor Author

l0b0 commented Jun 2, 2021

Err, yes. 😊 Didn't realise I'd already created this, but somehow the other issue got more attention. Feel free to close either of them.

@l0b0 l0b0 mentioned this issue Jun 3, 2021
4 tasks
@duckontheweb
Copy link
Contributor

duckontheweb commented Jun 11, 2021

Duplicate of #390

@duckontheweb duckontheweb marked this as a duplicate of #390 Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants