Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default middleware in stac_fastapi.api.app.StacApi #265

Closed
vincentsarago opened this issue Sep 14, 2021 · 1 comment
Closed

Remove default middleware in stac_fastapi.api.app.StacApi #265

vincentsarago opened this issue Sep 14, 2021 · 1 comment

Comments

@vincentsarago
Copy link
Member

Having a compression middleware is a nice thing but IMO it shouldn't be included by default.

self.app.add_middleware(BrotliMiddleware)

My main motivation is that I often build my own custom application (and then choose what middleware to add) (e.g https://github.com/developmentseed/eoAPI/blob/master/src/eoapi/stac/eoapi/stac/app.py#L34-L44)

@geospatial-jeff
Copy link
Collaborator

closed in #267, thanks @vincentsarago !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants