Skip to content

Commit

Permalink
ci(pre-commit): Install dependencies needed for cargo test (#441)
Browse files Browse the repository at this point in the history
* Revert "fix(template): Run commands in a nix-shell to automatically pull the necessary dependencies"

This reverts commit 56f72e0.

* ci(pre-commit): install dependencies needed for cargo test
  • Loading branch information
NickLarsenNZ authored Sep 19, 2024
1 parent 932368c commit 60551e9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion template/.github/workflows/pr_pre-commit.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- name: Install host dependencies
uses: awalsh128/cache-apt-pkgs-action@a6c3917cc929dd0345bfb2d3feaf9101823370ad # v1.4.2
with:
packages: protobuf-compiler krb5-user libkrb5-dev libclang-dev liblzma-dev libssl-dev pkg-config apt-transport-https
version: ubuntu-latest
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
fetch-depth: 0
Expand Down Expand Up @@ -40,7 +45,6 @@ jobs:
chmod 700 "${LOCATION_BIN}"

echo "$LOCATION_DIR" >> "$GITHUB_PATH"
- uses: cachix/install-nix-action@8887e596b4ee1134dae06b98d573bd674693f47c # v26
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
with:
extra_args: "--from-ref ${{ github.event.pull_request.base.sha }} --to-ref ${{ github.event.pull_request.head.sha }}"
4 changes: 2 additions & 2 deletions template/.pre-commit-config.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ repos:
- id: regenerate-charts
name: regenerate-charts
language: system
entry: nix-shell --run 'make regenerate-charts'
entry: make regenerate-charts
stages: [commit, merge-commit, manual]
pass_filenames: false

- id: cargo-test
name: cargo-test
language: system
entry: nix-shell --run 'cargo test'
entry: cargo test
stages: [commit, merge-commit, manual]
pass_filenames: false

0 comments on commit 60551e9

Please sign in to comment.