feat: Include aliases toBeSameAs and toBe for toBeSame #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -472,6 +471,28 @@ describe("[Unit] Assertion.test.ts", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe(".toBeSameAs", () => { | |||
There was a problem hiding this comment.
These are the changes that matter in this file for this PR.
| @@ -440,6 +444,48 @@ export class Assertion<T> { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
These are the changes that matter in this file for this PR.
JoseLion
reviewed
Oct 30, 2023
|
Hi @JoseLion I reverted the code formatter changes. Let me know if looks better now. |
JoseLion
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Looks great! Thanks for your contribution @CristhianMotoche 🎉
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Include
toBeSameAsandtoBealias fortoBeSame.NOTE: My code formatter modified some files. Let me know if it's okay to keep it that way, otherwise I can revert that to keep only the necessary changes.
Solves #108
As part of Stack Builders Inc. Hacktoberfest 2023 event.