fix(core): Allow arrays of plugins on usePlugin(..) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseLion
commented
Jan 24, 2024
Comment on lines
+28
to
+29
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export function usePlugin<P extends Plugin<any, Assertion<any>>>(plugins: P | P[]): void { |
There was a problem hiding this comment.
I wish there were a better way to get rid of these any, but without them, the argument cannot accept an array of union types. For example, [Plugin<X, XAssertion>, Plugin<Y, YAssertion>] will not work.
JoseLion
force-pushed
the
fix/plugins-usage
branch
from
aa765b0 to
f9025ef
Compare
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins might consist of multiple assertion instances. These plugins might want to expose a single variable to be used by the
usePlugin(..)function, so we need the argument so accept a single plugin (for backward compact) or an array of them.