feat(assertion): Add .toBeInstanceOf(Constructor) matcher
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseLion
force-pushed
the
feat/add-instance-of-matcher
branch
from
e0670de
to
2ac753e
Compare
JoseLion
commented
Aug 26, 2022
| @@ -3,7 +3,7 @@ import { isDeepStrictEqual } from "util"; | |||
|
|
|||
| import { Assertion } from "./Assertion"; | |||
|
|
|||
| export type JSObject = Record<keyof any, unknown>; | |||
| export type JSObject = Record<keyof any, any>; | |||
There was a problem hiding this comment.
This change fixes issues with type inference in generic constraints. The type unknown is too specific to be part of a constraint
byrpatrick
requested changes
Aug 26, 2022
There was a problem hiding this comment.
@JoseLion is looking good!
I left some comments and suggestions!
In general, I think it's more natural to relate an instance with a class and not with its constructor.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a
.toBeInstanceOf(Constructor)matcher to the the baseAssertion<T>class.