Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Extension mechanism #81

Merged
merged 2 commits into from
Feb 5, 2023
Merged

feat(core): Extension mechanism #81

merged 2 commits into from
Feb 5, 2023

Conversation

JoseLion
Copy link
Member

@JoseLion JoseLion commented Nov 23, 2022

Add an extension mechanism that allows users to add instances of Assertion<T> to the logic within the expect(..) function. These are added in the form of a Plugin<T, A extends Assertion<T> object, which contains the necessary information to determine where and when the instance is returned by the expect(..) function.

Additionally, the PR adds another example workspace called @examples/symbol-plugin, which shows how a plugin can be created as a 3rd-party library. Then the plugin is used and tested in both @examples/jest and @examples/mocha workspaces.

@JoseLion JoseLion requested a review from a team November 23, 2022 22:53
@JoseLion JoseLion self-assigned this Nov 23, 2022
@JoseLion JoseLion marked this pull request as ready for review November 25, 2022 23:00
Copy link
Contributor

@alejo0o alejo0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome new feature 🤯 👍

@JoseLion JoseLion merged commit 439eba3 into main Feb 5, 2023
@JoseLion JoseLion deleted the feat/extension-mechanism branch February 5, 2023 01:27
@JoseLion
Copy link
Member Author

JoseLion commented Mar 1, 2023

@all-contributors please add @alejo0o for review

@allcontributors
Copy link
Contributor

@JoseLion

I've put up a pull request to add @alejo0o! 🎉

@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants