Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Drop duplicated all from cycle packages name #57

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: Drop duplicated all from cycle packages name #57

merged 1 commit into from
Mar 21, 2024

Conversation

sestrella
Copy link
Member

@sestrella sestrella commented Mar 13, 2024 •
edited
Loading

The word all appears twice in the names of the cycle packages:

this derivation will be built:
  /nix/store/vqn18gq4sd0v24v48rxv16nhyw4dv6rp-terraform-all-all-1.6.drv

@sestrella sestrella requested a review from oscar-izval March 13, 2024 08:07
oscar-izval
oscar-izval approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@oscar-izval oscar-izval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sestrella sestrella merged commit 90cb77d into main Mar 21, 2024
11 checks passed
@sestrella sestrella deleted the fix_cycle_packages_name branch March 21, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscar-izval oscar-izval oscar-izval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sestrella @oscar-izval