Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return a 500 error when dns zone does not exist. #16

Closed
2 tasks done
busilina opened this issue Mar 14, 2024 · 2 comments
Closed
2 tasks done

Do not return a 500 error when dns zone does not exist. #16

busilina opened this issue Mar 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@busilina
Copy link

Is your feature request related to a problem? Please describe.

If for some reason the dns zone does not exist (anymore), the webhook returns InternalServerError . This causes the external-dns pod to come in a CrashLoop.

Describe the solution you'd like

I think it would be better to just give a (maybe a warn) log. E.g., dns zone missing and just continue without an error.

Describe alternatives you've considered

As an alternative maybe it's more appropriate to return a NotFound error (I am not sure if the external-dns would still crash since this is an error as well).

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

I'm not sure if this is a requirement from the external-dns itself, but I feel that this is a very hard error handling. And I would like to discuss this with you. Thanks for your effort!

@busilina busilina added the enhancement New feature or request label Mar 14, 2024
@PatrickKoss
Copy link
Collaborator

I think we talked in person about it and come to conclusion we should adjust external dns for graceful error handling. If there are is still a problem, feel free to open the issue again.

@busilina
Copy link
Author

Yes, we already have opened a PR in external-ds to handle this. This would solve our problem once merged. Thanks for the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants